Fix issue #3: contributions page - cancel call to ohsome when a component is unloaded#4
Open
justb4 wants to merge 1 commit intoosm-es-4.7.0from
Open
Fix issue #3: contributions page - cancel call to ohsome when a component is unloaded#4justb4 wants to merge 1 commit intoosm-es-4.7.0from
justb4 wants to merge 1 commit intoosm-es-4.7.0from
Conversation
Signed-off-by: Taylor Smock <tsmock@meta.com>
Collaborator
Author
|
Complete workflow this PR (see also https://github.com/OSM-es/servidores/blob/master/tareas/pasos-reparar-login-4.7.0.md?plain=1#L106): Apply Cherry-pick Nr 2 for /contributions page failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Example: Fixes #3
Describe this PR
The function
fetchExternalJSONAPI()was called with an extra boolean parameter. This caused the exception.This was a known issue in core TM version and was fixed in commit:
hotosm@56da86b
As we run from aa 4.7.0 already cherrypicked branch, a new cherrypick is required.
Screenshots
Alternative Approaches Considered
No.
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?
Good, hopefully now the contributions page https://tareas.openstreetmap.es/contributions will work again!