Fix dev setup issues with pooch data fetch and cache handling#1656
Conversation
- Add pooch to dev requirements - Ensure pooch cache directory is created if missing - Improve data fetch (retry + timeout) - Document USE_POOCH setup for local environments
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1656 +/- ##
==========================================
+ Coverage 85.58% 85.75% +0.17%
==========================================
Files 79 78 -1
Lines 6998 7040 +42
==========================================
+ Hits 5989 6037 +48
+ Misses 1009 1003 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LOCEANlloydizard
merged commit 147f1ad
into
OSOceanAcoustics:main
| retry_if_failed=5, | ||
| ) | ||
|
|
||
| downloader = pooch.HTTPDownloader(timeout=300) |
There was a problem hiding this comment.
Hey @LOCEANlloydizard : I am curious - is this a safety measure because you saw whole bunch of failed attempts?
There was a problem hiding this comment.
yes, after I deleted the local cache directory, it started downloading again and I got several timeout errors! But I mostly saw this locally, not on CI (if I remember correctly). Maybe it's because the asset files are getting too large..?
In the long term, maybe we could reduce the number of retries and the timeout? or maybe that altogether?
3 participants
ok had a look & these small fixes should address the issues encountered in #1652! I was able to install echopype from scratch and run the test suite locally, so should be good!
@leewujung did not migrate dependencies to pyproject.toml as it would require broader refactoring, but this is trackded as an issue anyway in #1421
Cheers!
Fix #1652