Change compressor (zarr v2) to compressors (zarr v3)#1657
Merged
leewujung merged 2 commits intoOSOceanAcoustics:mainfrom Apr 19, 2026
Merged
Change compressor (zarr v2) to compressors (zarr v3)#1657leewujung merged 2 commits intoOSOceanAcoustics:mainfrom
leewujung merged 2 commits intoOSOceanAcoustics:mainfrom
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1657 +/- ##
==========================================
+ Coverage 85.58% 85.75% +0.17%
==========================================
Files 79 78 -1
Lines 6998 7040 +42
==========================================
+ Hits 5989 6037 +48
+ Misses 1009 1003 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Looks like this solves the reported problem! I'll go ahead to merge this now. Thanks @ctuguinay for checking this. Onward to fix the next warning! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug surfaced in running the krill_freq_diff.pynb notebook on echopype-examples: OSOceanAcoustics/echopype-examples#92
It turns out Zarr v3 supports condec chaining so instead of compressor, it uses compressors (plural)! The example is given in the Zarr documentation: https://docs.xarray.dev/en/stable/user-guide/io.html#zarr-compressors-and-filters
I also found this test is not doing anything. It might be something that was functioning but then something got changed so the test is no longer needed -- @LOCEANlloydizard if you have a moment could you confirm I am not mistaking, that the
lazy_encodingsis indeed empty? If so, maybe we drop it?@ctuguinay : I think this is why your temp fix to do
compress=Falseworked in OSOceanAcoustics/echopype-examples#89, but it's not the root of the problem.