fix: correct variable syntax and add missing set -e in setup_misp.sh#40
Open
piyush140104 wants to merge 3 commits intoOWASP:masterfrom
Open
fix: correct variable syntax and add missing set -e in setup_misp.sh#40piyush140104 wants to merge 3 commits intoOWASP:masterfrom
piyush140104 wants to merge 3 commits intoOWASP:masterfrom
Conversation
Author
|
Hey @adrianwinckles, when you have a moment can you please review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #39
Two fixes in
honeytraps/misp/setup_misp.sh:{$DOCKER_ROOT}→${DOCKER_ROOT}, broken brace syntax made theDOCKER_ROOT guard never trigger
set -u→set -eu, addedeflag so failed docker commandsstop the script instead of silently continuing
Before this fix, the DOCKER_ROOT guard never triggered due to wrong brace syntax
{$DOCKER_ROOT}, causing the script to silently run chown and mkdir with broken paths. Additionally, missingset -emeant a faileddocker pullwould not stop the script it would continue and crash later with a confusing unrelated error. After this fix, any misconfiguration is caught immediately at startup with a clear error message.