fix: add missing format placeholders in log.error and log.debug calls

[piyush140104]

What

Added missing %s placeholders in 5 logging calls in honeytraps/waf_modsec/preprocess-modsec-log.py.

Fix

log.debug("Processed file lines: %s", procIndex) # line 95
log.debug("Original file lines: %s", origIndex) # line 97
log.debug("Head: %s", index) # line 101
log.debug("Write Mode: %s", writeMode) # line 102
log.error("Error writing to file: %s", e) # line 117

Reviewers

@adrianwinckles

Test

import logging
logging.basicConfig(level=logging.ERROR)
log = logging.getLogger('test')
log.error("Error writing to file", Exception("disk full"))
#Before: triggers --- Logging error --- TypeError, actual error never logged
log.error("Error writing to file: %s", Exception("disk full"))
#After: ERROR:test:Error writing to file: disk full

Closes #59

[Copilot]

Pull request overview

Fixes incorrect Python logging calls in the ModSecurity log preprocessing script that previously caused TypeError formatting failures and suppressed useful log output.

Changes:

• Add missing %s placeholders to log.debug(...) calls in processLog.
• Add missing %s placeholder to a log.error(...) call in the file-write exception handler.

Comments suppressed due to low confidence (1)

honeytraps/waf_modsec/preprocess-modsec-log.py:106

• lines can be None when the original log file is missing (see getLines returning None on FileNotFoundError), but processLog still calls len(lines) in the loop. This will raise a TypeError and stop processing; consider treating missing files as an empty list or returning early with a log message when lines is None.

        log.debug("Write Mode: %s", writeMode)

        # Log line prasing/modification
        newLines = []
        for i in range(index, len(lines)):

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The file handle may be left open if an exception occurs during file.write(...) (since file.close() is only reached on the success path). Using a context manager (with open(...) as f:) avoids leaks and also simplifies the code; also consider log.exception(...) or log.error(..., exc_info=True) here so the traceback is captured for operational debugging.