fix: replace hardcoded private IP with Docker service name in logstash.conf#71
Open
piyush140104 wants to merge 2 commits intoOWASP:masterfrom
Open
fix: replace hardcoded private IP with Docker service name in logstash.conf#71piyush140104 wants to merge 2 commits intoOWASP:masterfrom
piyush140104 wants to merge 2 commits intoOWASP:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem?
While exploring the mlogc_elk setup, I noticed that mlogc/logstash.conf has a hardcoded private IP address (192.168.136.88:9200) as the Elasticsearch host. This IP belongs to the original developer's local machine and does not exist on anyone else's network. So when any other contributor tries to run the mlogc_elk stack, Logstash silently fails to connect to Elasticsearch and no logs get shipped basically the whole pipeline breaks.
What I fixed
Replaced the hardcoded IP with elk:9200, which is the actual Docker service name defined in docker-compose.yml. Docker resolves this name correctly inside the container network for everyone.
File: mlogc_elk/mlogc/logstash.conf
Before: hosts => ["192.168.136.88:9200"]
After: hosts => ["elk:9200"]
Fixes #70