feat(myopencre): improve CSV import error handling in UI #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Validate file type, encoding, and required headers - Accept CSVs generated from CRE catalogue export - Skip empty and padding rows present in exported templates - Validate CRE format only when CRE references exist - Guard against misaligned rows with extra columns - Return structured validation errors before import This keeps the importer aligned with the exporter while preventing malformed inputs from causing server errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this PR after the above PR is merged.
Scope note (important)
The intended change in this PR is limited to:
application/frontend/src/pages/MyOpenCRE/MyOpenCRE.tsxAny other file diffs shown by GitHub are inherited from branch history / stacking and are not part of the frontend error-handling change itself.
Please let me know if you’d prefer this rebased or split further.
Summary
This PR improves the MyOpenCRE frontend experience by surfacing clear, structured feedback for CSV import results, directly reflecting backend validation responses.
The goal is to make CSV imports easier to understand and debug for users, without changing any backend logic.
What this PR does
Frontend error handling
(row number + validation reason)
Success feedback
UX improvements
Screenshots
1. Empty CSV upload
2. Invalid CRE entry (
bad_cre.csv)3. Misaligned CSV columns (
misaligned_columns.csv)4. Successful import (
valid.csv)What is intentionally out of scope
Why this approach
The backend now returns clear, structured validation responses.
This PR ensures those responses are presented cleanly in the UI, making CSV imports:
Feedback welcome
If there are UX improvements, edge cases, or error formats that should be handled differently, I’d really appreciate guidance and am happy to iterate.