refactor(oncdw): fix dual-timeseries routing, chart parameters, and backend validation - #1
Open
edmasononc wants to merge 3 commits into
Open
refactor(oncdw): fix dual-timeseries routing, chart parameters, and backend validation#1edmasononc wants to merge 3 commits into
edmasononc wants to merge 3 commits into
Conversation
edmasononc
commented
Jul 30, 2026
edmasononc
commented
- Fixed argument unpacking in _altair.py to resolve chart suppression (st_wrapper bug)
- Added strict "both-or-nothing" data validation in widget.py for dual-sensor plots
- Extended _query routing for seamless 24H, 7D, 2W stitching, and 1M downsampling
- Updated chart.py to use custom instrument labels in timestamp warnings
- Removed static selection names in Altair charts to eliminate deduplication warnings
…ackend validation - Fixed argument unpacking in _altair.py to resolve chart suppression (st_wrapper bug) - Added strict both-or-nothing data validation in widget.py for dual-sensor plots - Extended _query routing for seamless 24H, 7D, 2W stitching, and 1M downsampling - Updated chart.py to use custom instrument labels in timestamp warnings - Removed static selection names in Altair charts to eliminate deduplication warnings - Decoupled template backend logic into helpers.py and removed legacy sonar modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.