Skip to content

fix amount setting#39

Open
Jason-W123 wants to merge 1 commit into
mainfrom
fix-amount-eth
Open

fix amount setting#39
Jason-W123 wants to merge 1 commit into
mainfrom
fix-amount-eth

Conversation

@Jason-W123

Copy link
Copy Markdown
Contributor

We force user to use AMOUNT as env var, but it doesn't use it when deposit ethers, so this pr also let the script use AMOUNT for ethers deposit.

@gzeoneth gzeoneth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is quite unclear what env are needed to be configured, can we move to use dotenv and provide a .env.example? Also the amount feels more like an arg than sth that should be configured in env tbh

@Jason-W123

Copy link
Copy Markdown
Contributor Author

It is quite unclear what env are needed to be configured, can we move to use dotenv and provide a .env.example? Also the amount feels more like an arg than sth that should be configured in env tbh

I remember we used to use dotenv before, but it changed to this now, do you have any ideas on this @GreatSoshiant ?

@robin-rrt

Copy link
Copy Markdown

Any update on merging this yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants