Skip to content

feat(ical): use meetupTimestamp as event start when available - #228

Merged
Olen merged 4 commits into
mainfrom
feat/ical-meetup-timestamp
May 14, 2026
Merged

feat(ical): use meetupTimestamp as event start when available#228
Olen merged 4 commits into
mainfrom
feat/ical-meetup-timestamp

Conversation

@Olen

@Olen Olen commented Apr 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Match events return both startTimestamp (kickoff) and meetupTimestamp ("oppmøtetid" — when participants should arrive). Today the ICS example only surfaces kickoff, so subscribers see no hint of the earlier meet-up.
  • Use meetupTimestamp as the ICS event begin when present, falling back to startTimestamp for events without a meet-up (e.g. training events).
  • Added an inline comment in the example explaining the two timestamps.

Test plan

  • Run examples/ical.py against a group with both training and match events; confirm match VEVENT DTSTART matches the meet-up time and training events are unchanged.

Olen added 2 commits April 28, 2026 11:56
Match events expose a `meetupTimestamp` ("oppmøtetid" in Norwegian) that
sits before `startTimestamp` (kickoff). Calendar subscribers care about
when to show up, not just when the match starts, so prefer the meet-up
time as the ICS event begin and fall back to startTimestamp when no
meet-up is set (e.g. training events).
@Olen Olen added the updateme Automatically update PR from main label May 14, 2026
@Olen
Olen merged commit c20c713 into main May 14, 2026
3 checks passed
@Olen
Olen deleted the feat/ical-meetup-timestamp branch May 14, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

updateme Automatically update PR from main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant