Integrate with GitHub job summaries (closes #7) - #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Closes #7 — Integrate kickflip with GitHub Actions job summaries so deployment change output is shown on the workflow run summary page in addition to the pull request comment.
Key decisions
GithubJobSummaryServicethat appends markdown to the file referenced by theGITHUB_STEP_SUMMARYenvironment variable (GitHub Actions' mechanism for job summaries).OutputService.GetChangesMarkdownoutput for the summary content, keeping a single source of truth for the rendered table.github pull-requesthandler so it runs alongside the PR comment (both integrations coexist).Files changed
src/kickflip/Services/GithubJobSummaryService.cs(new)src/kickflip/Program.cs— invoke job summary service after posting PR commentsrc/kickflip.Tests/GithubJobSummaryServiceTests.cs(new)README.md— documented the job summary behaviourVerification
dotnet build— 0 errorsdotnet test— 12 passedBlockers
None.