RALPH: Upgrade to .NET 10 (closes #15) - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Upgrade the kickflip tool and test project from .NET 8 to .NET 10 (closes #15, related duplicate #16).
Key decisions
TargetFrameworkfromnet8.0tonet10.0in bothkickflip.csprojandkickflip.Tests.csproj.LangVersionfrom 12 to 14 to match the .NET 10 / C# 14 toolchain.actions/setup-dotnet@v4withdotnet-version: '10.0.x'to both the build (main.yml) and release (release.yml) workflows so CI provisions the .NET 10 SDK.bin/Release/net8.0/tobin/Release/net10.0/.dotnet build,dotnet test(51/51 passing), anddotnet packall succeed with no warnings.Files changed
src/kickflip/kickflip.csprojsrc/kickflip.Tests/kickflip.Tests.csproj.github/workflows/main.yml.github/workflows/release.ymlBlockers for next iteration
None. Note: issue #16 is a duplicate of #15 and can be closed without additional work.