feat: AOT/trimming support for Results and MinimalApi#61
Merged
Conversation
OliverVea
commented
Mar 28, 2026
| /// Gets the exception that caused the problem, if any. | ||
| /// </summary> | ||
| [JsonIgnore] | ||
| public Exception? Exception { get; } |
Owner
Author
There was a problem hiding this comment.
I don't like that we just throw away the exception. We should make a public string ExceptionSummary => ... property and take that in in our json ctor.
…ripping Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[JsonConstructor]for deserialization,[JsonIgnore]onException/OriginInformation/Args/Message, andFormattedMessageproperty for clean serialized output. Fixes IL2026 trimming warnings and noisy API surface.ResultandResult<T>enabling reflection-free type checking.MakeGenericMethodreflection withIResultTypeinterface check, fixing IL3053 AOT warnings.Olve.ResultsandOlve.MinimalApiprojects.Closes #59, closes #60
Test plan
TreatWarningsAsErrors)🤖 Generated with Claude Code