fix(docker): lock the e2e runner's cargo test dependency graph - #1596
Merged
Conversation
Follow-up to PR #1567's CodeRabbit review: the `Dockerfile.audit` build already uses --locked, but the e2e service's `cargo test` invocation in compose.audit.yml did not, so the audit-image builder stage could silently resolve a different dependency graph for the test binary than Cargo.lock pins. All other items from that review round (admin-key interpolation, the headless binary's production refusal gate, the DATABASE_URL-free error message, embedded-Postgres cleanup on both shutdown paths, and the DOCKER-APP-TESTING doc corrections) already landed on main via the earlier follow-up commits on that PR branch — verified present here before making this change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe audit E2E runner now passes Cargo’s ChangesAudit E2E test execution
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the CodeRabbit review round on #1567. Re-checked every item from that review against current
mainbefore touching anything:docker/compose.audit.yml, both services) — already onmain:OLYMPUS_ADMIN_KEY: ${OLYMPUS_ADMIN_KEY:?set OLYMPUS_ADMIN_KEY before running the audit harness}.src-tauri/src/bin/olympus-server.rs) — already onmain:OLYMPUS_ENV=production/prodexits 2 before any DB work.DATABASE_URL-free error message — already onmain: generic "Could not connect to external database..." message, no interpolated URL.main: bind-failure path callsstop_db()beforeexit(2); normal shutdown reportsstop_db()errors instead of unconditionally claiming success.docker/Dockerfile.audit--locked— already onmain.DOCKER-APP-TESTING-2026-07-28.md— already onmain: output fences taggedtext, run instructions requireOLYMPUS_ADMIN_KEY.One gap remained: the
e2eservice'scargo testinvocation indocker/compose.audit.ymlwas still missing--locked, so the audit-image builder stage could silently resolve a different dependency graph for the test binary thanCargo.lockpins (theDockerfile.auditbuild step already had this flag, but the compose-level test command didn't). This PR adds it.Test plan
cat docker/compose.audit.yml | pnpm exec prettier --check --stdin-filepath docker/compose.audit.yml— passes cleancargo clippy --workspace -D warnings, full nextest suite incl. embedded-Postgres binaries, doctests) — all greenmainprior to this change🤖 Generated with Claude Code
Summary by CodeRabbit