Rebase dev onto upstream dev - #5
Closed
OlympusLedgerOrg wants to merge 16 commits into
Closed
Conversation
* chore: run clippy on all platforms * Only install dependencies for linux * Use cross on Android * mac clippy * mobile clippy * run on `macos-latest` * duplicated cargo * mac clippy suggestion take 2 * ios clippy * Exclude tauri-cli and tauri-bundler on mobile * Exclude `tauri-cli-node` * just test api example on mobile * Fix audit * Android clippy * Run the event handler in test
…pps#15677) * chore(deps): serial_test 3.5.0 to deal with RUSTSEC advisory * add change file
…ix tauri-apps#15583) (tauri-apps#15604) * fix(core): purge JS event listeners when source webview is destroyed (fix tauri-apps#15583) JS event listeners registered from a webview are stored in the backend Listeners::js_event_listeners map keyed by the source webview label. When the webview was destroyed the manager removed its handle but left the listener entries behind. Their JS runtime no longer exists, so the callbacks can never be delivered and the metadata leaked until app exit, forcing apps to manually unlisten() before closing a window. Add Listeners::remove_webview_events and call it from on_webview_close and on_window_close so a destroyed webview's listeners are dropped with it. * refactor(core): rename remove_webview_events to remove_webview_js_listeners Clarify that this only purges JS-side listeners, matching the js_event_listeners map it operates on. Addresses @Legend-Master's review feedback. * style(core): rustfmt remove_webview_js_listeners call site
…ri-apps#15643) * chore: rename LICENSE files to use dashes instead of underscores cargo-about doesn't detect the license files because of the underscore in their names (`LICENSE_APACHE-2.0`, `LICENSE_MIT`). Rename them to the dashed form (`LICENSE-APACHE-2.0`, `LICENSE-MIT`), matching the more common convention, and update the relative-path pointer files under crates/tauri-driver and crates/tests/restart accordingly. Closes tauri-apps#15243 * chore: rename bundler license files to use dashes
…uri-apps#15224) * tauri-runtime-wry: avoid leaking ObjC retains in with_webview WebviewMessage::WithWebview converted Retained<T> values to raw pointers with Retained::into_raw on Apple targets, transferring ownership without a corresponding release in this path. Use scoped Retained bindings and Retained::as_ptr for pointer handoff to the callback payload. This preserves borrowing semantics for callback lifetime and keeps Objective-C retain/release balanced when the retained values drop after callback return. Fixes tauri-apps#15210 * chore: add changes file for tauri-apps#15210 * changes: fix covector metadata for objc leak patch Format .changes/fix-objc-retain-leak.md with valid covector front matter and package bump metadata. This resolves CI failures in check-change-tags and covector status for this PR. * chore(tauri-runtime-wry): document Apple Webview pointer fields Add a doc/TODO note on the Apple with_webview pointer fields (webview/manager/ns_window/view_controller): they're borrowed from ObjC Retained handles and must not be mutated through, and should become *const c_void in v3. * refactor(tauri-runtime-wry): simplify pointer cast in with_webview Apply Legend-Master's suggestion: use .cast_mut() instead of casting through *const c_void first, across all macOS/iOS with_webview fields.
* chore: fix new clippy warnings from 1.97
* fix mac
* Put in `{}`
|
Important Review skippedToo many files! This PR contains 344 files, which is 44 over the limit of 300. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (13)
📒 Files selected for processing (344)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Owner
Author
|
Follow-up for Socket SCA alerts:
Remaining Socket items appear to be heuristic "obfuscated code" detections or existing allowed maintenance warnings rather than actionable CVE updates. |
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Owner
Author
|
@SocketSecurity ignore cargo/openssl@0.10.80 |
Owner
Author
|
Superseded by #6, which keeps the upstream rebase and includes the local CodeRabbit review fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devontotauri-apps/tauri:devc71c0d03tao/wryport commits replayed on topNotes
devwas rejected because the branch is protected and does not allow force-pushes.