Fix Wry port review findings - #9
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR updates Wry callback thread-safety contracts, custom protocol validation, native platform error handling, benchmark publishing, workflow pinning, workspace metadata, and project documentation. ChangesWry maintenance and robustness
Estimated code review effort: 4 (Complex) | ~45 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ports/wry/.changes/readme.md`:
- Line 3: Change the attribution heading in ports/wry/.changes/readme.md to use
the existing repository convention of heading level 5 (`#####`), matching
`.changes/README.md` and keeping it subordinate to `# Changes`.
In `@ports/wry/.github/workflows/bench.yml`:
- Around line 101-111: Serialize benchmark publication for the matrix workflow
instead of letting each job push independently. Move the gh-pages update logic
from the “push new benchmarks” step into a single post-matrix job, or implement
a serialized fetch, rebase, and push-retry loop around the existing benchmark
publication commands so all matrix results are retained.
In `@ports/wry/SECURITY.md`:
- Line 18: Replace the generic “here” link text in SECURITY.md with descriptive
text such as “GitHub’s private vulnerability reporting guidance,” while
preserving the existing destination URL.
- Around line 12-16: Update the security reporting policy text in SECURITY.md to
replace references to “Tauri” with “Wry,” including the dependency wording, so
it clearly applies to Wry and its upstream dependencies.
In `@ports/wry/src/wkwebview/mod.rs`:
- Around line 112-128: Update cookie_domain_matches so a leading-dot cookie
domain matches the exact host as well as subdomains. After normalizing both
domains, allow strip_suffix to succeed with an empty prefix, while still
requiring a dot boundary for non-empty prefixes; preserve the existing
case-insensitive exact-match handling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f074d8b1-f018-45d5-bce6-e28176ac9327
📒 Files selected for processing (24)
ports/wry/.changes/readme.mdports/wry/.github/ISSUE_TEMPLATE/feature_request.mdports/wry/.github/workflows/bench.ymlports/wry/.github/workflows/covector-comment-on-fork.ymlports/wry/CHANGELOG.mdports/wry/Cargo.tomlports/wry/LICENSE.spdxports/wry/MOBILE.mdports/wry/SECURITY.mdports/wry/build.rsports/wry/examples/async_custom_protocol.rsports/wry/examples/custom_titlebar.rsports/wry/examples/streaming.rsports/wry/src/android/main_pipe.rsports/wry/src/android/mod.rsports/wry/src/custom_protocol_workaround.rsports/wry/src/error.rsports/wry/src/lib.rsports/wry/src/webview2/util.rsports/wry/src/wkwebview/class/document_title_changed_observer.rsports/wry/src/wkwebview/class/wry_download_delegate.rsports/wry/src/wkwebview/class/wry_web_view_ui_delegate.rsports/wry/src/wkwebview/download.rsports/wry/src/wkwebview/mod.rs
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
ports/wry/.github/workflows/bench.yml (1)
101-119: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winRun this step with Bash on Windows.
push new benchmarksuses Bash-only syntax, but this matrix includeswindows-latestand the step has noshell: bash, so it will fail there before publishing. Addshell: bashor rewrite the loop in PowerShell.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ports/wry/.github/workflows/bench.yml` around lines 101 - 119, Configure the “push new benchmarks” workflow step to run with Bash by adding an explicit shell setting, ensuring its Bash-specific loop and commands work on windows-latest before publishing.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@ports/wry/.github/workflows/bench.yml`:
- Around line 101-119: Configure the “push new benchmarks” workflow step to run
with Bash by adding an explicit shell setting, ensuring its Bash-specific loop
and commands work on windows-latest before publishing.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: cda23fa3-1c0e-44c2-9b4b-d5ec3504c173
📒 Files selected for processing (3)
ports/wry/.github/workflows/bench.ymlports/wry/SECURITY.mdports/wry/src/wkwebview/mod.rs
✅ Files skipped from review due to trivial changes (1)
- ports/wry/SECURITY.md
🚧 Files skipped from review as they are similar to previous changes (1)
- ports/wry/src/wkwebview/mod.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split
Part 3 of 3 replacing #6.
Validation
Summary by CodeRabbit