fix(security): replace vulnerable extract-zip with path-safe extractor - #35
Merged
Conversation
fix(security): replace vulnerable extract-zip with path-safe extractor - Remove extract-zip (GHSA-jmr9-qjv8-65gv: unvalidated symlink path traversal, no patched version available). - Add src/lib/safe-extract.js using node-stream-zip; rejects absolute paths, ".." traversal, and symlink entries before writing (zip-slip safe). - Wire into restore (src/restore/index.js). - tests/safe-extract.test.js: path-guard units + real zip-slip archive refused with nothing written outside destination. - npm audit: 0 vulnerabilities. 105/105 tests pass, lint + headers clean. - Docs: DEPENDENCY-LICENSE-REVIEW advisory marked resolved; CHANGELOG updated. @
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes extract-zip (GHSA-jmr9-qjv8-65gv — symlink path traversal, no patched version) and replaces it with node-stream-zip behind
src/lib/safe-extract.js, which rejects absolute paths,..traversal, and symlink entries before writing (zip-slip safe).npm auditnow reports 0 vulnerabilities.tests/safe-extract.test.js: path-guard unit tests + a real byte-patched zip-slip archive that is refused with nothing written outside the destination.No co-authors.