Skip to content

fix(cleanup): simple 21-day age-based retention + OAuth token (closes #33) - #36

Merged
OmarRao merged 1 commit into
mainfrom
fix/issue-33-retention
Aug 26, 2026
Merged

fix(cleanup): simple 21-day age-based retention + OAuth token (closes #33)#36
OmarRao merged 1 commit into
mainfrom
fix/issue-33-retention

Conversation

@OmarRao

@OmarRao OmarRao commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Closes #33.

  • Retention: default 21 days (was 90); weekly Sunday schedule kept.
  • Auth fix: cleanup now uses the OAuth refresh token (createAuthClient) like backup/restore — previously it used an invalid GoogleAuth keyFile on the client-secret.
  • Removed GFS theater: dropped the retention_policy input, GFS_* env, and log lines that claimed a Grandfather-Father-Son policy the code never implemented.
  • Docs corrected: README + USERGUIDE (8.3, FAQ, 19.6, SOX row) now describe the actual simple age-based, chain-aware retention.
  • The chain-aware safety guard (never delete a bundle a retained delta chain needs) is retained.

Security/quality: added a CodeQL workflow (security-and-quality queries) to populate GitHub code scanning; Dependabot alerts are currently 0.

QA: 105/105 tests pass, ESLint clean, SPDX headers present, all workflow YAML valid. No co-authors.

@
fix(cleanup): simple 21-day age-based retention + OAuth token; add CodeQL (closes #33)

Per issue #33:
- Retention default 21 days (was 90); keep the weekly Sunday schedule.
- Cleanup now authenticates with the OAuth refresh token via
  GoogleDriveClient.createAuthClient (was an invalid GoogleAuth keyFile on the
  client-secret) — matches backup/restore.
- Remove the GFS theater from cleanup.yml (retention_policy input, GFS_* env,
  and the log lines that claimed a policy the code never implemented).
- Docs: corrected README + USERGUIDE 8.3/FAQ/19.6/SOX to describe the actual
  simple age-based (chain-aware) retention. Chain-protection safeguard retained.

Security/quality:
- Add CodeQL workflow (security-and-quality queries) to populate GitHub code
  scanning; Dependabot alerts currently 0.

105/105 tests pass, lint + headers clean, all workflow YAML valid.
@
@OmarRao
OmarRao merged commit 58d0ba2 into main Aug 26, 2026
@OmarRao OmarRao mentioned this pull request Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revise cleanup retention

1 participant