fix: apply requireAdmin middleware to admin user management routes#79
Open
FLASH2332 wants to merge 1 commit intoOneBusAway:mainfrom
Open
fix: apply requireAdmin middleware to admin user management routes#79FLASH2332 wants to merge 1 commit intoOneBusAway:mainfrom
FLASH2332 wants to merge 1 commit intoOneBusAway:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
/api/v1/admin/users/*routes only validated JWT signature and expiry viarequireAuth,but did not check the caller's role. Any authenticated driver could create, delete, and modify
all user accounts—including promoting themselves to admin or deleting other admins.
Solution
Applied the existing
requireAdminmiddleware to all five admin user management routes:GET /api/v1/admin/usersGET /api/v1/admin/users/{id}POST /api/v1/admin/usersPUT /api/v1/admin/users/{id}DELETE /api/v1/admin/users/{id}Routes now use
authMiddleware(adminMiddleware(...))to verify both JWT validity and admin role.Changes
adminMiddlewareSecurity Impact
403 Forbiddeninstead of succeeding/api/v1/admin/status,/api/v1/admin/vehicles/*)Closes #75