Skip to content

Add Keyboard.io atreus support#11

Merged
severindupouy merged 2 commits into
OneDeadKey:mainfrom
doc75:atreus_inner
May 22, 2026
Merged

Add Keyboard.io atreus support#11
severindupouy merged 2 commits into
OneDeadKey:mainfrom
doc75:atreus_inner

Conversation

@doc75

@doc75 doc75 commented May 14, 2026

Copy link
Copy Markdown
Contributor

The layout is using the thumb keys highlighted in yellow in the picture below:
image

I did not rebase to avoid breaking the commit IDs referenced in the issue, but I could do it if deemed necessary.
If anything is missing, please let me know and I’ll do my best to correct this.

@doc75

doc75 commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

I just realized that a test suite existed and it is failing fully for the atreus ;-(
I’ll see if I understand how to make them pass....

@doc75

doc75 commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

I found a first issue (already solved in the generator.sh) linked to qmk config outpout parsing.
I'll push it along with this commit.
But this does not solve the failure as it fails one step further.
The error seems to be linked to the fact that the define in the config.h is not known (for one of the test it puts ONEDEADKEY_LAYOUT_SELENIUM_LAYOUT which is not defined.

Are those tests supposed to work with any keyboard ?

Here is my qmk config in case it can help reproduce:

ind.keymap=default (config)
mass_compile.keymap=default (config)
user.keyboard=keyboardio/atreus (config)
user.keymap=selenium (config)
user.qmk_home=/home/user/git/keyboard/qmk_firmware (config)

@doc75

doc75 commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

I was able to understand why the tests are failing.
Indeed, generator.sh is not used with the -layout option, therefore based on my qmk config value for user.keyboard, it does not use the proper define.
I tried with an hard-coded value and all the tests are passing.

Should we enhance the generator.sh to have a mapping between the keyboard name in qmk config and the layout to be used in generator.sh ?

I can propose something, but I am not sure to get all the mapping for the existing defines...

@doc75

doc75 commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

@severindupouy as per our last discussion, we agreed that the generator.sh point raised in my previous comment will be handled separately.

I let the commit related to the proper parsing of the QMK config value in common.sh (same code pushed in 73731b7)

This PR is ready for review.

@severindupouy

severindupouy commented May 22, 2026

Copy link
Copy Markdown
Collaborator

@doc75 Can you :

  • rebase the branch on main, dropping commits d560422 and df7bddf
  • keep only the 87a5ce0 about atreus support

I'll open soon a new PR about generator refactor, I'll notice you If you want to review it.

Edit: sorry I haven't well followed your different actions in the repo last 2 weeks, so I made some work in parallel of you. I used to work alone here. ^^ I now had activated all notifications, so I'll see correctly future activity.

Comment thread tests/common.sh
@doc75

doc75 commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

@severindupouy cleaning is done as requested. If I missed anything, please let me know.

Comment thread tests/common.sh Outdated
@severindupouy severindupouy merged commit b4100dc into OneDeadKey:main May 22, 2026
3 checks passed
@doc75 doc75 deleted the atreus_inner branch May 23, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants