chore!: 更新依赖#2103
Conversation
无breaking changes 锁定numpy到2.2.6防止soundcard依赖问题,如果soundcard更新则可取消numpy锁定 已测试3.13
概览更新了 变更
预期代码审查工作量🎯 2 (简单) | ⏱️ ~10 分钟 诗
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Line 29: Upgrade to pyinstaller==6.19.0 requires validating that the spec
files and runtime hook still work: inspect deploy/OneDragon-RuntimeLauncher.spec
and deploy/OneDragon-Launcher.spec for uses of Analysis, EXE, PYZ, COLLECT and
update their argument usage to match PyInstaller 6.19.0 signatures; review
deploy/hook_path_inject.py for any sys.path.insert / __path__.append
manipulations and ensure runtime hook import semantics still apply; run the
supplied grep commands (or equivalent) to find all usages of from
PyInstaller.building.api/build_main imports and calls to
Analysis()/EXE()/PYZ()/COLLECT() and adjust parameters or migration patterns per
PyInstaller 6.19.0 release notes, updating spec/hook code accordingly before
merging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8510408b-1c80-4bbe-97d2-3139397bd26a
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
| "matplotlib==3.10.8", | ||
| "polib==1.2.0", | ||
| "pyinstaller==6.7.0", | ||
| "pyinstaller==6.19.0", |
There was a problem hiding this comment.
pyinstaller==6.19.0 需要先回归验证现有 spec/hook 的兼容性。
Line 29 升级跨度较大;deploy/OneDragon-RuntimeLauncher.spec(Line 1-41, 62-77)、deploy/OneDragon-Launcher.spec(Line 19-40)以及 deploy/hook_path_inject.py(Line 1-22)都依赖 PyInstaller 的构建 API 与运行时 hook 行为,建议合并前完成兼容性核对。
#!/bin/bash
set -euo pipefail
echo "== PyInstaller 相关导入与构建调用 =="
rg -n --type=py -C2 'from PyInstaller\.building\.(api|build_main) import|Analysis\(|EXE\(|PYZ\(|COLLECT\(' deploy
echo
echo "== runtime hook 的路径注入与包路径修改 =="
rg -n --type=py -C2 'sys\.path\.insert|__path__\.append|import one_dragon' deploy/hook_path_inject.pyPyInstaller 6.19.0 的 Analysis/EXE/PYZ/COLLECT 参数签名是否与 6.7.0 保持兼容?官方文档或发布说明里有哪些 breaking/deprecation 需要迁移?
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pyproject.toml` at line 29, Upgrade to pyinstaller==6.19.0 requires
validating that the spec files and runtime hook still work: inspect
deploy/OneDragon-RuntimeLauncher.spec and deploy/OneDragon-Launcher.spec for
uses of Analysis, EXE, PYZ, COLLECT and update their argument usage to match
PyInstaller 6.19.0 signatures; review deploy/hook_path_inject.py for any
sys.path.insert / __path__.append manipulations and ensure runtime hook import
semantics still apply; run the supplied grep commands (or equivalent) to find
all usages of from PyInstaller.building.api/build_main imports and calls to
Analysis()/EXE()/PYZ()/COLLECT() and adjust parameters or migration patterns per
PyInstaller 6.19.0 release notes, updating spec/hook code accordingly before
merging.
无breaking changes
锁定numpy到2.2.6防止soundcard依赖问题,如果soundcard更新则可取消numpy锁定
已测试3.13
Summary by CodeRabbit