Repository navigation
Add AGI/ASI governance blueprint, artifact starter pack, validator, tests, and CI workflow - #66
Merged
OneFineStarstuff merged 1 commit intoApr 27, 2026
Conversation
|
The files' contents are under analysis for test generation. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review these changes at https://app.gitnotebooks.com/OneFineStarstuff/OneFineStarstuff.github.io/pull/66 |
Reviewer's GuideAdds a 2026–2030 AGI/ASI governance blueprint plus a regulator artifact starter pack, implements a Python-based validator and Bash runner with tests, wires them into a new GitHub Actions workflow, and relocates a legacy tests tree listing into the artifact package. Sequence diagram for running blueprint artifact checks via CI runner scriptsequenceDiagram
actor Developer
participant GitHub
participant GitHubActions
participant RunnerScript as run_blueprint_artifact_checks_sh
participant Validator as validate_blueprint_artifacts_py
participant Pytest
participant Files as Blueprint_Artifacts
Developer->>GitHub: push_or_pull_request
GitHub->>GitHubActions: trigger_workflow_blueprint-artifacts-validation
GitHubActions->>RunnerScript: bash scripts/run_blueprint_artifact_checks.sh --list-checks
RunnerScript->>Validator: python validate_blueprint_artifacts.py --list-checks
Validator-->>RunnerScript: print_check_ids
RunnerScript-->>GitHubActions: exit_0
GitHubActions->>RunnerScript: bash scripts/run_blueprint_artifact_checks.sh --skip-install --skip-pytest --output-json /tmp/blueprint-validation-alt.json
RunnerScript->>Validator: python -m json.tool T6_Evidence_Manifest.json
Validator-->>RunnerScript: validate_json_syntax
RunnerScript->>Validator: python validate_blueprint_artifacts.py
Validator->>Files: load_manifest_schema_csv_rego_yaml
Files-->>Validator: artifact_contents
Validator-->>RunnerScript: validation_results
RunnerScript->>Validator: python validate_blueprint_artifacts.py --json > output_json
Validator-->>RunnerScript: json_results
RunnerScript->>Validator: python validate_blueprint_artifacts.py --base-dir docs/reports/blueprint_artifacts
Validator-->>RunnerScript: validation_results
RunnerScript->>Validator: python -m json.tool output_json
Validator-->>RunnerScript: json_ok
alt pytest_not_skipped
RunnerScript->>Pytest: pytest -q tests/test_validate_blueprint_artifacts.py tests/test_run_blueprint_artifact_checks.py
Pytest-->>RunnerScript: tests_pass
end
RunnerScript-->>GitHubActions: exit_status
GitHubActions-->>Developer: report_success_or_failure
Class diagram for Python blueprint artifact validator structureclassDiagram
class ValidationResult {
+str name
+bool ok
+str detail
}
class ValidatorModule {
+load_manifest(base_dir: Path) dict
+load_schema(base_dir: Path) dict
+validate_presence(base_dir: Path) ValidationResult
+validate_json_manifest(base_dir: Path) ValidationResult
+validate_manifest_timestamp(base_dir: Path) ValidationResult
+validate_schema_metadata(base_dir: Path) ValidationResult
+validate_manifest_against_schema_contract(base_dir: Path) ValidationResult
+validate_schema_constraints(base_dir: Path) ValidationResult
+validate_csv_headers(base_dir: Path) ValidationResult
+validate_rego_guardrails(base_dir: Path) ValidationResult
+validate_yaml_examples(base_dir: Path) ValidationResult
+safe_run(name: str, fn: Callable, base_dir: Path) ValidationResult
+run_validations(base_dir: Path) list~ValidationResult~
+parse_args() argparse.Namespace
+main() void
}
ValidationResult "1" <.. "*" ValidatorModule : returns
ValidatorModule ..> Path : uses
ValidatorModule ..> dict : uses
ValidatorModule ..> csv : uses
ValidatorModule ..> json : uses
ValidatorModule ..> yaml : uses
ValidatorModule ..> datetime : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
View changes in DiffLens |
Contributor
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (18)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View changes in DiffLens |
Contributor
|
Failed to generate code suggestions for PR |
![gstraccini[bot]](https://avatars.githubusercontent.com/in/480132?s=60&v=4){kind=small}
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| BestPractice | 5 minor |
| Security | 6 medium 1 minor 16 high |
| CodeStyle | 67 minor |
| Complexity | 1 critical 4 medium |
🟢 Metrics 124 complexity · 0 duplication
Metric Results Complexity 124 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84b07a2d2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The schema/manifest contract checks currently require the manifest’s top-level keys and artifact keys to exactly match the schema
requiredset, which prevents adding optional fields in the future; consider relaxing this to ensure required keys are a subset while allowing additional properties. - There is duplicated mapping between check IDs and functions in
CHECK_SEQUENCEandcheck_map; you could derive one from the other (e.g., store callables alongside descriptions) to avoid drift when new checks are added or renamed. - The GitHub Actions workflow only runs the script with
--list-checksand then a separate smoke block, but never executes the full default validation path with tests enabled; consider adding a step that runsrun_blueprint_artifact_checks.shwithout--list-checks/--skip-pytestto mirror local usage and catch integration issues.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The schema/manifest contract checks currently require the manifest’s top-level keys and artifact keys to exactly match the schema `required` set, which prevents adding optional fields in the future; consider relaxing this to ensure required keys are a subset while allowing additional properties.
- There is duplicated mapping between check IDs and functions in `CHECK_SEQUENCE` and `check_map`; you could derive one from the other (e.g., store callables alongside descriptions) to avoid drift when new checks are added or renamed.
- The GitHub Actions workflow only runs the script with `--list-checks` and then a separate smoke block, but never executes the full default validation path with tests enabled; consider adding a step that runs `run_blueprint_artifact_checks.sh` without `--list-checks`/`--skip-pytest` to mirror local usage and catch integration issues.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
❌ Deploy Preview for onefinestarstuff failed.
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
docs/reports/ENTERPRISE_CIVILIZATIONAL_AGI_ASI_BLUEPRINT_2026_2030.mdand a starter artifact pack underdocs/reports/blueprint_artifacts/(T1–T9 plusREADME.md, manifest and schema examples).scripts/validate_blueprint_artifacts.py, a standalone Python validator that runs a sequence of checks (presence,manifest_structure,manifest_timestamp,schema_metadata,schema_contract,schema_constraints,csv_semantics,rego_guardrails,yaml_examples) and can emit JSON results.scripts/run_blueprint_artifact_checks.sh, a smallscripts/requirements-blueprint-validator.txt,scripts/__init__.py, and unit teststests/test_validate_blueprint_artifacts.pyandtests/test_run_blueprint_artifact_checks.pyto exercise the validator and runner..github/workflows/blueprint-artifacts-validation.ymlto run consolidated smoke checks and invoke the runner on relevant pushes and pull requests.teststree listing intodocs/reports/blueprint_artifacts/notes/tests_tree_legacy.txtas part of the artifact packaging.Testing
python scripts/validate_blueprint_artifacts.py --jsonand it produced JSON-formatted results without error.bash scripts/run_blueprint_artifact_checks.sh --skip-install --skip-pytest --output-json /tmp/blueprint-validation-alt.jsonand verified the output is valid JSON usingpython -m json.tool.pytest -q tests/test_validate_blueprint_artifacts.py tests/test_run_blueprint_artifact_checks.pyand all tests passed.Codex Task
Summary by Sourcery
Introduce a regulator-focused AGI/ASI governance blueprint with a starter artifact pack, plus automation to validate artifacts and enforce checks in CI.
New Features:
Enhancements:
CI:
Tests: