fix: [SDK-4744] remove stale package-lock.json pinning vulnerable vitest#208
Merged
Merged
Conversation
The repo migrated to bun (bun.lock) but a leftover package-lock.json remained, pinning vitest@3.0.9 and triggering a Dependabot alert for CVE-2026-47429 (GHSA-5xrq-8626-4rwp, critical). package.json already overrides vitest to a patched version; the stale lockfile is the only source of the vulnerable pin.
fadi-george
approved these changes
Jun 3, 2026
Collaborator
|
🎉 This PR is included in version 3.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One Line Summary
Remove the leftover
package-lock.jsonthat pins a vulnerablevitest@3.0.9, clearing the critical Dependabot alert (CVE-2026-47429).Motivation
Dependabot flagged a critical vulnerability (CVE-2026-47429 / GHSA-5xrq-8626-4rwp, CVSS 9.8) for
vitest < 4.1.0. The repo'spackage.jsonalready overridesvitestto a patched version (@voidzero-dev/vite-plus-test@0.1.21), but a stalepackage-lock.json— leftover from before the migration to bun (bun.lock) — still pinnedvitest@3.0.9, which is the only source of the vulnerable pin.Scope
package-lock.jsononly.bun.lockis the real lockfile and is unchanged.package-lock.jsonornpm ciin CI.web-shim-codegen(scripts/patch-repo.sh) stops future syncs from preserving stale lockfiles, so this won't regress.Testing
bun.lockis present and is the lockfile used byvp/CI.package-lock.json/npm ciremain in the repo (only user-facing install docs).Checklist
vitest