Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/knowledge-search-omit-use-agentic.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ontos-ai/knowhere-sdk": patch
---

Omit unset `useAgentic` in `Knowledge.search` so the API map-nav default applies instead of forcing classic retrieval.
24 changes: 24 additions & 0 deletions src/knowledge/__tests__/knowledge.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -780,6 +780,30 @@ describe('Knowledge', () => {
});
});

it('should omit useAgentic when unset so API map-nav default applies', async () => {
const cacheDirectory = await createTempDirectory();
const { client, retrievalQuery } = createClient(createParseResult());
const knowledge = new Knowledge(client, { cacheDirectory });
await knowledge.parseToLocalCache({
url: 'https://example.com/report.md',
localDocumentId: 'local-report',
});

await knowledge.search({
query: 'margin',
namespace: 'support-center',
localDocumentIds: ['local-report'],
topK: 2,
});

expect(retrievalQuery).toHaveBeenCalledWith({
query: 'margin',
namespace: 'support-center',
topK: 2,
useAgentic: undefined,
});
});

it('should search through Knowhere API retrieval', async () => {
const cacheDirectory = await createTempDirectory();
const { client, retrievalQuery } = createClient(createParseResult());
Expand Down
3 changes: 2 additions & 1 deletion src/knowledge/knowledge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,8 @@ export class Knowledge {
query: params.query,
namespace: params.namespace,
topK: params.topK,
useAgentic: params.useAgentic ?? false,
// Omit when undefined so the API default (map-nav) applies; false → classic.
useAgentic: params.useAgentic,
});
const documentByServerId = new Map(
localDocuments
Expand Down
Loading