Preserve staging configuration in ECS task definitions - #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This keeps the Fargate migration behavior aligned with the current EKS staging workloads while retaining intentional ECS differences: IAM task-role S3 credentials, public service URLs, and
ENVIRONMENT=staging.Part of Ontos-AI/knowhere-api-infra#21, Ontos-AI/knowhere-api-infra#22, and Ontos-AI/knowhere-api-infra#19.
Verification
uv run pytest deploy/ecs/test_render_task_definitions.py -q(6 passed)uv run pytest apps/api/tests apps/worker/tests/contract -q(388 passed)make lintmake typecheckuv lock --checkgit diff --checkknowhere-stagingusingkubectl --context aws-knowhere-prodNo AWS, Kubernetes, database, queue, or deployment changes were made.
Deployment Notes
Changed non-secret staging environment values include
S3_TEMP_PATH, API/worker pool sizes, provider URLs,SUPPORTED_EXTENSIONS, worker PDF controls, model selections, and parser-column compatibility. No migration or queue-routing change is included. Merge tomainonly; do not promote tostaginguntil ECS prerequisites exist because a staging push automatically attempts migration and ECS deployment.Checklist