fix tiny var bug - #2547
Merged
Merged
Conversation
I was just looking through the repo to understand it better and noticed this error is using the wrong var
|
Looks good. I fixed this when I noticed it in #2332 as well, but it’s not related and shouldn’t be held up by that. |
mracsys
approved these changes
Apr 2, 2026
Collaborator
|
I think this could be triggered via TOCTOU, but regardless, I'd say this is minor enough that testing can be skipped. Thanks for the PR! |
fenhl
added
Type: Bug
Collaborator
|
While I'm merging this, I'm also going to fix the indentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was just looking through the repo to understand it better and noticed this error is using the wrong var
Testing
I did not test the thrown exception, and in fact I don't think this exception can even trigger due to the check on line 257, but for some reason the undefined var ref bothered me enough to bring attention to this lol.
The only reason I didn't remove the try catch in my PR is because if memory serves Windows can have os.path.isfile return true but still fail to open the file with a file not found error if the file path is too long or something