Use indefinite articles for items in hints in multiworld - #2569
Open
fenhl wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the way hints refer to items to avoid implying that the hint refers to the player's own item when it's in fact ambiguous. This affects most hint types, but not ones that always refer to the player's own items such as the Dampé diary and Ganondorf hints. It also only applies in multiworld and only for items that are shuffled across worlds, e.g. not songs on songs, and only with Clearer Hints enabled (or for messages that always use the clearer item names).
To implement this, I separated item texts from the remaining hint texts, and added a column to the new table for the “indefinite” text.
Testing
Rolled a seed with multiworld tournament base settings, which has songs on songs. Checked the gossip stones section of the spoiler log and found hints working as expected: