Skip to content

Hookshot parent softlock fix - #2595

Open
djevangelia wants to merge 1 commit into
OoTRandomizer:Devfrom
djevangelia:hookshotparent
Open

Hookshot parent softlock fix#2595
djevangelia wants to merge 1 commit into
OoTRandomizer:Devfrom
djevangelia:hookshotparent

Conversation

@djevangelia

Copy link
Copy Markdown

Pulling out Hookshot when player already has a parent set that isn't Hookshot results in player being stuck in fly-land-fly. Player can move slowly, pause and enter scene transitions, but if there are none reachable it's a softlock state.

In vanilla this is rare, easiest is probably patrol Moblin in water, but I know it's been done with Like like too. However, if enemies that grab player and set themselves as parent can spawn in new areas, this increases the risk of this happening (like falling down En_Holl and get despawned while grabbing).

Fix: When checking if player should start Hookshot flying, ensure that the parent actor really is Hookshot.

There are other oddities with having a parent set, but considering this can force a reset and the fix doesn't impact anything else, I think it's good to preemptively fix this even if it is rare/impossible to encounter right now and the rest can be left to when new enemy spawns are added (ensure each enemy removes parent if they are destroyed while grabbing player etc).

Testing

Tested in ares recent nightly release and Project64 3.0.1.
Softlock and fix look like this: https://www.youtube.com/watch?v=2BrYwUpd4rE
The C fix has been merged into SoH develop branch HarbourMasters/Shipwright@53b9db5

For quick testing this can be used, set player to parent:

if (z64_game.common.input[0].pad_pressed.dl) {
        z64_link.common.parent = &z64_link.common;
}

@fenhl fenhl added Type: Bug Something isn't working Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it labels Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants