Object_LoadExtra, note on EffectSs and zero unloaded entry id - #2596
Open
djevangelia wants to merge 1 commit into
Open
Object_LoadExtra, note on EffectSs and zero unloaded entry id#2596djevangelia wants to merge 1 commit into
Object_LoadExtra, note on EffectSs and zero unloaded entry id#2596djevangelia wants to merge 1 commit into
Conversation
fenhl
added
Component: ASM/C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rrealmuto pointed out that
EffectSsaren't killed on room transition and some have an object dependency, which may pose a crash risk when extra object loading. I've gone through the effects that have an object dependency other thangameplay_keepand they all check that the object is loaded before draw except King Dodongo's magmasmoke 2, (Phantom) Ganon's lightballs, and Slingshot game score, which all crash on room transition. As I don't think anyone will spawn them anytime soon I've just added a note to the function on effects and objects.Added resetting objectslot id to 0 if an object is too large to be loaded. The vanilla function that sets slot data sets slot id to object id before size is checked. (In practice, this is a cosmetic bugfix because the game only cares about slot numbers below the number of loaded slots which is kept track of separately and not increased here.)