Improve cross-platform ASM toolchain discovery and Apple Silicon / arm64 support - #2603
Open
JackTriton wants to merge 1 commit into
Open
Improve cross-platform ASM toolchain discovery and Apple Silicon / arm64 support#2603JackTriton wants to merge 1 commit into
JackTriton wants to merge 1 commit into
Conversation
|
This just looks like slop to me. It doesn't even look like it even checks the PATH for a valid toolchain which is the default way to do it. The tools directory is there for people who don't know how to modify their PATH. I'm against even reviewing this because there is a clear lack of actual understanding of what is actually being done for randomizer and why. |
flagrama
suggested changes
Jul 12, 2026
| @@ -1,4 +1,4 @@ | |||
| Advanced modifications to the Randomzier source require a bit more software than what is needed for running it. | |||
| Advanced modifications to the Randomizer source require a bit more software than what is needed for running it. | |||
|
|
|||
There was a problem hiding this comment.
The only review I'll do is that the README file is so wordy as to be completely useless and ignored now. The readme should be the recommended path for each platform. Do not add a bunch of "do this or this" and "you can do this but it is optional". Create a new file for advanced concepts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve cross-platform ASM toolchain discovery and Apple Silicon support
This PR updates the ASM build script to support the Apple Silicon n64 toolchain without changing the existing Windows, Linux, or Intel macOS workflows.
Before this, both of these need to be merged:
Changes
Add common MIPS toolchain discovery for:
OOTR_N64_PREFIXPATHPlace generated toolchain wrappers under the shared
ASM/tools/toolchaindirectory.Ensure GCC, assembler, linker, objdump, and objcopy are selected from the same toolchain prefix.
Add an isolated assembler launch environment on Apple Silicon to avoid interference from Conda, MacPorts, or inherited compiler variables.
Clear
COMPILER_PATHandGCC_EXEC_PREFIXbefore invoking the toolchain.Add optional
mips64-g++support.Add:
This command reports the expected path, detected path, resolved path, version, ROM size, and GCC-selected assembler for every required file and executable.
Compatibility
The Apple Silicon-specific behavior is enabled only when running on Darwin arm64. Other platforms continue to use the existing direct tool execution path.