Option to enable bomb OI - #2604
Open
djevangelia wants to merge 4 commits into
Open
Conversation
|
That setting tooltip is going to have to be more detailed for casual players who don't already know what it is (me) |
Author
|
Yeah, I hope to get such suggestions here. I just want to type assembly into the computer 🤓 |
fenhl
added
Type: Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bomb OI was introduced in NTSC 1.1 by a fix to the empty bomb bug. Changes to two functions were necessary to create the bug: Player_DetachHeldActor and Player_UpperAction_CarryActor. This is assembly backport of the changes. Setting is added to enable/disable it. If bomb OI is disabled, the old empty bomb fix runs, so empty bomb bug remains fixed always.
Some players were interested in it on Discord which is why I made it.
Testing
Tested in ares old nightly release and Project64 3.0.1.
Looks like this: https://www.youtube.com/watch?v=te3R2PimZog
Tested to hold and drop/throw other actors too like rocks, Hookshot, Ruto which was ok. Also tested with bomb OI disabled, empty bomb fix still works.