Fix silver rupee counter not displaying in Ganon's castle - #2609
Merged
Conversation
GSKirox
added
Type: Bug
fenhl
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2518 added an entry to the dungeons array, but forgot to increment the dungeon_count variable, which is used to iterate on this array by the silver rupee counter display function.
So it was not displaying anything for the last dungeon in the array which is Ganon's Castle.
Testing
Shuffled Silver rupees, confirmed that the counter was not displayed in Ganon's castle at all.
Tested after this fix on Retroarch, and the counter is back.