Allow unqeuipping swords for blank B - #2614
Open
djevangelia wants to merge 2 commits into
Open
Conversation
fenhl
added
Type: Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1347
This lets player unequip sword and sets the swordless flag.
I didn't plan on making this but I ended up doing it for my own project so figure might as well submit it if it is of interest.
Thus I haven't made a setting or otherwise taken into consideration any specifics for rando and not including shields/tunics is intentional.
Testing
Tested in ares old nightly release and Project64 3.0.1.
Looks like this: https://www.youtube.com/watch?v=APxJlvlnmIg
Other equips and empty equips work as usual.
I haven't tested much else, but have no reason this would not behave like any other case of having swordless flag set and blank B.