Skip to content

Advanced Logic - Water Temple MQ Typo - #2615

Merged
fenhl merged 1 commit into
OoTRandomizer:Devfrom
shirosoluna:water_fixes
Aug 10, 2026
Merged

Advanced Logic - Water Temple MQ Typo#2615
fenhl merged 1 commit into
OoTRandomizer:Devfrom
shirosoluna:water_fixes

Conversation

@shirosoluna

Copy link
Copy Markdown

Discord #setup-support

typo found for MQ water, raise_water_level is named in vanilla / reset_water_level for MQ. There was an undefined mention in MQ

Testing

Confirmed it raised the same error
Screenshot 2026-08-10 at 10 12 03 AM
of undefined helper

Confirmed fix by running 5 seeds with advanced logic preset and all MQ.

Screenshot 2026-08-10 at 10 12 52 AM

@r0bd0g

r0bd0g commented Aug 10, 2026

Copy link
Copy Markdown

In vanilla you've got the raise and lower events. I called it something different in MQ because I only needed the one event to cover both raising and lowering since the requirements for them don't differ in MQ. Upon request I could explain why the requirements for raise and lower differ in vanilla but not in MQ. (The lower and reset events haven't made it into glitchless logic on main branch yet.)

@fenhl fenhl added Type: Bug Something isn't working Component: Logic Non-trivial changes to the JSON logic files Status: Needs Review Someone should be looking at it labels Aug 10, 2026
@cjohnson57 cjohnson57 removed the Status: Needs Review Someone should be looking at it label Aug 10, 2026
@shirosoluna

Copy link
Copy Markdown
Author

In vanilla you've got the raise and lower events. I called it something different in MQ because I only needed the one event to cover both raising and lowering since the requirements for them don't differ in MQ. Upon request I could explain why the requirements for raise and lower differ in vanilla but not in MQ. (The lower and reset events haven't made it into glitchless logic on main branch yet.)

water temple is special in advanced, so it's not as easy as 1:1. But did confirm perhaps we changed the name for MQ as its used throughout the logic. It just didnt get changed in the definition. It's used more than once in advanced for MQ.

if this is part of the souls logic changes though then going to have to tell racing about it.

@fenhl fenhl added this to the next milestone Aug 10, 2026
@fenhl
fenhl merged commit 4d6032b into OoTRandomizer:Dev Aug 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Logic Non-trivial changes to the JSON logic files Type: Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants