LRU Improvements #912
Open
LRU Improvements #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbaldyga
force-pushed
the
lru-improvements
branch
3 times, most recently
from
9ab3640 to
e27a3a0
Compare
Signed-off-by: Roel Apfelbaum <roel.apfelbaum@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Roel Apfelbaum <roel.apfelbaum@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Roel Apfelbaum <roel.apfelbaum@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Roel Apfelbaum <roel.apfelbaum@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Roel Apfelbaum <roel.apfelbaum@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
This contributes to less breakdown of big requests into many small ones. Signed-off-by: Roel Apfelbaum <roel.apfelbaum@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
This change may lead to wasting up to 31 cache lines but it simplifies OCF_LRU_GET_LIST_INDEX() macro with is heavily used in ocf_lru_hot_cline() Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Make best effort to evict contiguous cache line ranges to avoid splitting requests. Signed-off-by: Roel Apfelbaum <roel.apfelbaum@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Roel Apfelbaum <roel.apfelbaum@huawei.com> Signed-off-by: Ian Levine <ian.levine@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
The bug was fixed by adding lock when adding a cache line to LRU list. Rename ocf_lru_add to ocf_lru_add_locked and add wrapper function ocf_lru_add() with lock. Signed-off-by: Sara Merzel <sara.merzel@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Passing lru list id as a parameter allows to avoid calculating the id within the macro each time the lock is acquired or released. Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com> Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
When filling the cache with reads, there is a backfill running thread asynchronousy. Wait for cache I/Os to settle before checking the occupancy stats. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
robertbaldyga
force-pushed
the
lru-improvements
branch
from
71ee77a to
ff66766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.