Fix stream fallbacks for conversation responses#105
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
usestream=truebut the LLM provider implementspromptStreamWithStatswithoutpromptStreamJSONWithStats, which broke JSON-structured conversation flows.showthinking=trueuses safe non-stream code paths so thinking logs and legacy prompt methods remain compatible with providers lacking stream-JSON support.Description
canStreamJsonguard and use it to callpromptStreamJSONWithStatsonly when that method exists, falling back to non-stream methods otherwise in the agent loop (mini-a.js).showthinkingpath to prefer existing non-stream JSON/raw methods and to avoid entering streaming code paths that are incompatible with thinking logs.canStreamJsonchecks and fallbacks to the chatbot flow so chatbot-mode streaming behavior matches the agent flow.mini-a.jsand preserve streaming behavior when full stream APIs are available.Testing
node -c mini-a.jsto validate syntax and loading, which succeeded.ojob tests/miniAUtils.yamlto exercise the test suite, but it could not be executed in this environment because theojobcommand is not available (test run failed withcommand not found).