Draft
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Author
|
I've been using this for a few days, seems to be working as intended. |
XenHat
force-pushed
the
improved-detection-fixes
branch
2 times, most recently
from
4f79e57 to
4de0038
Compare
Author
|
|
XenHat
force-pushed
the
improved-detection-fixes
branch
2 times, most recently
from
dfea808 to
10d9750
Compare
|
fixes my issue with running thcrap patched touhou 7, cool pr |
balta3
reviewed
Jun 29, 2025
This comment was marked as resolved.
This comment was marked as resolved.
konovalov-nk
reviewed
Sep 4, 2025
konovalov-nk
reviewed
Sep 4, 2025
konovalov-nk
reviewed
Sep 5, 2025
XenHat
force-pushed
the
improved-detection-fixes
branch
4 times, most recently
from
57721dc to
2aba85d
Compare
neptuwunium
reviewed
Dec 30, 2025
XenHat
force-pushed
the
improved-detection-fixes
branch
from
42b80ec to
ddd283e
Compare
Some games are listed in the discord game database with their parent directories but their launched processes on linux don't always have this included in cmdline. This fixes that by checking processes with their working directories as well. For example, this will now detect DOOM Eternal running through proton.
XenHat
force-pushed
the
improved-detection-fixes
branch
from
ddd283e to
88e1b34
Compare
XenHat
force-pushed
the
improved-detection-fixes
branch
2 times, most recently
from
bb16b9c to
a4600ff
Compare
konovalov-nk
reviewed
Feb 9, 2026
konovalov-nk
reviewed
Feb 9, 2026
konovalov-nk
reviewed
Feb 9, 2026
|
Last but not least, please lets use |
XenHat
commented
Feb 9, 2026
XenHat
force-pushed
the
improved-detection-fixes
branch
2 times, most recently
from
2b6d8bd to
d3ec42b
Compare
XenHat
commented
Feb 12, 2026
Author
XenHat
left a comment
XenHat
left a comment
There was a problem hiding this comment.
Looks good so far. I tried to reduce as many changes as possible.
XenHat
force-pushed
the
improved-detection-fixes
branch
6 times, most recently
from
f43637f to
07b78d7
Compare
changes: - several performance improvements - match against more (malformed?) game database entries - added simple unit tests
XenHat
force-pushed
the
improved-detection-fixes
branch
from
07b78d7 to
ea121fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-implementation of #92 with additional fixes for more games, and should be compatible with #130 as I have validated the code against the current upstream database.
The following games have been verified to be correctly detected on Linux:
KNOWN ISSUES:
Main changes:
Additional credit: