[Docs] Correct notebook FilePathUrlConverter -> FileUrlPathConverter#118
Merged
feltech merged 1 commit intoOpenAssetIO:mainfrom May 15, 2025
Merged
Conversation
63684eb to
896466d
Compare
Member
|
Thanks for this! The changes look good, just a couple of issues with the commit itself.
I.e. add the Thanks again! |
896466d to
79685bf
Compare
FilePathUrlConverter to `FileUrlPathC…Closes OpenAssetIO#116. Correct class name in Jupyter Notebook from FilePathUrlConverter to FileUrlPathConverter. Signed-off-by: prathik <prathik.karanth@gmail.com>
79685bf to
8b7e169
Compare
Contributor
Author
|
My bad, should've read the commit guidelines. I've pushed the new changes, let me know if they're fine now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116