fixup exit early version_check.py#213
Open
julianneswinoga wants to merge 1 commit intoOpenAstroTech:developfrom
Open
fixup exit early version_check.py#213julianneswinoga wants to merge 1 commit intoOpenAstroTech:developfrom
julianneswinoga wants to merge 1 commit intoOpenAstroTech:developfrom
Conversation
hasn't been screwed with. (instead of bailing out right at the start)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On non-FW changes still do version checks to make sure the version hasn't been screwed with. (instead of bailing out right at the start).
Previously a CI-only change could've also changed the FW version/changelog version. This prevents that