Allow discovery of "minecraft" folders (without dots)#142
Merged
OpenBagTwo merged 3 commits intodevfrom Mar 28, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #140
List of Changes
gathercommand to search for folders named "minecraft" in addition to files named ".minecraft"collections.abcinstead oftyping(as the latter is deprecated)Tech Debt and Other Concerns
Validation Performed
Using this version of EnderChest, I ran the following command to "gather" an instance that had recently been created by PrismLauncher:
After that, linking to that instance worked as expected.
PR Type
require a bump in the minor version)
release (will require rebasing off of
release)Checklist:
mkdocs servelocally and ensured that all API docs andchanges I have made to the static pages are rendering correctly, with all links
working
accepted
the GNU Public License v3