Skip to content

Allow discovery of "minecraft" folders (without dots)#142

Merged
OpenBagTwo merged 3 commits intodevfrom
dotless
Mar 28, 2025
Merged

Allow discovery of "minecraft" folders (without dots)#142
OpenBagTwo merged 3 commits intodevfrom
dotless

Conversation

@OpenBagTwo
Copy link
Copy Markdown
Owner

Summary

Addresses #140

List of Changes

  • Updates gather command to search for folders named "minecraft" in addition to files named ".minecraft"
  • Updates imports to pull various abstract base classes from collections.abc instead of typing (as the latter is deprecated)

Tech Debt and Other Concerns

Validation Performed

Using this version of EnderChest, I ran the following command to "gather" an instance that had recently been created by PrismLauncher:

$ enderchest gather instance instances/NewInstance/
Could not parse instance name from /home/openbagtwo/minecraft/instances/NewInstance/instance.cfg
Gathered MMC-like Minecraft installation from instances/NewInstance/minecraft

Starting with Minecraft 1.20, Mojang by default no longer allows worlds
to load if they are or if they contain symbolic links.
Read more: https://help.minecraft.net/hc/en-us/articles/16165590199181
==> Would you like EnderChest to add /home/openbagtwo/minecraft/EnderChest to /home/openbagtwo/minecraft/instances/NewInstance/minecraft/allowed_symlinks.txt?
==> [Y/n] y
/home/openbagtwo/minecraft/instances/NewInstance/minecraft/allowed_symlinks.txt updated.
EnderChest configuration written to /home/openbagtwo/EnderChest/enderchest.cfg

After that, linking to that instance worked as expected.

PR Type

  • This PR introduces a breaking change (will
    require a bump in the minor version)
  • The changes in this PR are high urgency and necessitate a hotfix or patch
    release (will require rebasing off of release)
  • This is a release (staging) PR (maintainer use only)

Checklist:

  • I have read the contributor's guide
  • I have run mkdocs serve locally and ensured that all API docs and
    changes I have made to the static pages are rendering correctly, with all links
    working
  • All tech debt concerns have been resolved, documented as issues, or otherwise
    accepted
  • I agree to license my contribution to this project under
    the GNU Public License v3

@OpenBagTwo OpenBagTwo merged commit b74380a into dev Mar 28, 2025
13 checks passed
@OpenBagTwo OpenBagTwo deleted the dotless branch March 28, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant