Skip to content

fix(smd): query parameter asssignment#83

Merged
synackd merged 1 commit into
mainfrom
fix-smd-query
May 18, 2026
Merged

fix(smd): query parameter asssignment#83
synackd merged 1 commit into
mainfrom
fix-smd-query

Conversation

@Wafffle77
Copy link
Copy Markdown
Collaborator

Pull Request Template

Thank you for your contribution! Please ensure the following before submitting:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

Added a line to apply the query parameters to the URL. The logic for constructing the query string is present, it just wasn't being applied properly.

Fixes #68

Type of Change

  • Bug fix

For more info, see Contributing Guidelines.

Signed-off-by: Ethan Clark <ethan.clark@trojans.dsu.edu>
@aheil-lanl
Copy link
Copy Markdown

I was able to confirm, this fixes what I reported in #68. Thanks!

@synackd synackd self-requested a review May 18, 2026 19:35
Copy link
Copy Markdown
Collaborator

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@synackd synackd merged commit a73a3f6 into main May 18, 2026
12 checks passed
@synackd synackd deleted the fix-smd-query branch May 18, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Filtering SMD interfaces does not apply query parameters

3 participants