feat(tabs): redesign tab layout — floating browser-style cards#175
Open
BunsDev wants to merge 2 commits into
Open
feat(tabs): redesign tab layout — floating browser-style cards#175BunsDev wants to merge 2 commits into
BunsDev wants to merge 2 commits into
Conversation
…eedback Elevate tab-state legibility in the live new-tab-styling path: - Active tab now carries a full-width 2px accent underline pinned to its bottom edge, visually connecting it to the content area below (the editor/terminal convention used by VS Code, Zed, Windows Terminal). It is a pure `ParentBySize` overlay, so it adds no height and never reflows the strip — tab height stays 34px and drag/drop layout is unaffected. - Inactive tabs now brighten their border on hover (fg_overlay_1 -> fg_overlay_2) to match the existing background lift, giving clear cursor feedback instead of a background-only change. Both reuse existing theme accessors (theme.accent(), internal_colors); no hardcoded colors and no new design primitives. Legacy (flag-off) path is untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the tab container rendering to make the active tab state more visually distinct (accent underline) and improve hover feedback, targeting the NewTabStyling feature-flag path.
Changes:
- Brightens tab border color on hover (in the
NewTabStylingbranch) for clearer pointer feedback. - Adds a feature-flagged active-tab accent underline as an overlay (no layout reflow).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1630
to
+1634
| // Mark the active tab with a full-width accent underline pinned to its | ||
| // bottom edge, visually connecting it to the content area below. The bar | ||
| // is a pure overlay (`ParentBySize` stretches it to the tab width) so it | ||
| // adds no height and never reflows the strip. | ||
| let tab_element: Box<dyn Element> = if FeatureFlag::NewTabStyling.is_enabled() && is_active |
Reshape the new-tab-styling strip from abutting square separators into a calmer, modern floating-card layout: - Rounded-top cards (6px) with a flat bottom that merges into the content area below — the browser/editor tab silhouette. - Replace the per-tab separator borders with a small 2px gap between tabs; idle tabs are now fully transparent and borderless for an uncluttered strip. - Active/hovered cards get a subtle top+side outline (open bottom); the active tab additionally keeps its accent underline along the flat edge, making the selected tab unmistakable. - Roomier inner horizontal padding (8 -> 10px) for better text rhythm. All colors come from existing theme accessors (theme.accent(), internal_colors::fg_overlay_*), which are translucent and stack correctly over the strip background. Legacy (flag-off) path is untouched. Verified: cargo check -p warp-app --bin cast-codes --features gui (clean). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
BunsDev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redesigns the terminal tab layout for the live
NewTabStylingpath (the default-feature path in OSS builds), moving from abutting square separators to a calmer, modern floating-card layout. The previous strip distinguished the active tab only by a faint background fill and divided every tab with hard 1px separators.Layout changes (
app/src/tab.rs)The active-tab accent underline is a
theme.accent()bar pinned to the bottom edge as aParentBySizeoverlay, so it adds no height and never reflows the strip — tab height stays 34px and drag/drop + ghost layout are unaffected. It now lands on the card's flat bottom, reading like a browser/editor active tab connected to its content.Design-system compliance
theme.accent(),internal_colors::fg_overlay_*). These overlays are translucent (foreground @ 5–10%) and stack correctly over the strip'sfg_overlay_1background, so hover/active stay clearly visible. No hardcoded colors, no new primitives.CornerRadius::with_topandParentBySizeoverlay idioms already used elsewhere in the codebase.Verification
cargo check -p warp-app --bin cast-codes --features gui— clean (full compile of the rendering code under the pinned 1.92 toolchain, Metal shaders built).rustfmt --check app/src/tab.rs— clean.is_first_tabseparator logic fully removed (no dangling refs).cargo clippysurfaces a pre-existingunnecessary_unwraplint incrates/warpui_core(double_click_handler) — unrelated to this change (untouched code; a stricter local clippy-driver 0.1.95 vs the pinned 1.92). CI's clippy (which passed on recent PRs over the same code) is the authoritative check..appbuild — happy to run it on request.🤖 Generated with Claude Code