Conversation
…mentation ID of each observation. This allows it to pass the unit test "HasIOFileConsistency", which ensure that now information is lost when a track is written to disk and restored. Note that this increases the size of the tracks file by 40%,
… and segmentation ID of each observation. This allows it to pass the unit test "HasIOFileConsistency", which ensure that now information is lost when a track is written to disk and restored. Note that this increases the size of the tracks file by 40%," This reverts commit 3d54bc3.
…n ID and instance ID are recovered from the file (they are not stored in the current OpenDroneMap file version). This is specific to OpenDroneMap, my guess is that this is a speed/size performance optimization.
Merged
Thanks for saving me the check.
So this mainly is intended to take the existing forked OpenSfM and ensure it builds with a follow-on for pulling in latest. I wonder if @YanNoun would have tips on that process. Regardless, sounds like a reasonable division. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gets OpenSfM to compile in the Docker Ubuntu 24.04 environment.
This codebase has diverged substantially from the upstream mapillary version. I'd like to move them closer together, but I think it is best to make that a follow-on effort.
The CI workflow fails. It also fails in the currently-used
357branch.