Open
Conversation
check maximum allowed length of service data for incoming mailbox validate minimum required mailbox size
Set cnt value just before a mailbox message is sent. Adjust bitfield for cnt value within mailbox header structure.
* fix: correct abort code for not supported complete access * add description for complete_access_subindex_loop() and remove redundant parameter
Consider possible change of number of subindexes of type array for ca download
Affected to previous bugfix 'allow ca access for objects with flexible length'.
Add validation of toggle bit for sdo segmented upload and download
During iteration of an object, non-existent subindices have to be considered.
Contributor
|
Can you guys please squash functional commits + fixes tied to functional commits? Would make life easier for us to review. thanks |
This was referenced Jun 3, 2025
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abort sdo download request if size exceeds allowed length.
Only accept ca download if size matches.
Fix complete access of bit data types.
Allow ca access for objects with flexible length.
Correct validation of sdo segmented request.
Serve correct datatype for SDO get object description.
Correct size limit for complete access.
(Also included: Pull-Request #194 and #197 )