fix: remove keychain from credential type picker grid#4452
Open
fix: remove keychain from credential type picker grid#4452
Conversation
Keychain credentials are only relevant in the workflow canvas context. Selecting the keychain type from the project or user credentials pages caused a crash because no keychain.json schema file exists. Move the keychain option out of get_type_options (shown on all credential picker pages) and conditionally include it only when from_collab_editor is true, so it remains available in the canvas advanced picker.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4452 +/- ##
==========================================
+ Coverage 89.37% 89.38% +0.01%
==========================================
Files 425 425
Lines 20194 20196 +2
==========================================
+ Hits 18048 18053 +5
+ Misses 2146 2143 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elias-ba
force-pushed
the
fix/keychain-credential-type-crash
branch
from
a089550 to
9b57c38
Compare
elias-ba
force-pushed
the
fix/keychain-credential-type-crash
branch
from
9b57c38 to
33481c1
Compare
elias-ba
changed the title
taylordowns2000
approved these changes
Feb 24, 2026
Contributor
Author
|
Don't merge yet. Let me add a regression test. |
Contributor
Author
|
Can be merged now. Test is added. Thanks @taylordowns2000 for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the Keychain option from
get_type_optionsso it no longer appears in the credential type picker grid. To keep it available in the workflow canvas advanced picker, it's conditionally added back totype_optionswhenfrom_collab_editoris true.Closes #4453
Validation steps
Additional notes for the reviewer
AI Usage
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)