fix: dismiss critic feedback widget when new events arrive (#641)

openhands_cli/tui/modals/exit_modal.tcss

@@ -25,7 +25,7 @@ SwitchConversationModal {
     padding: 2 0;
 }
 
-Button {
+#dialog Button {
     width: 100%;
     height: 3;
     margin: 0 1;

openhands_cli/tui/widgets/richlog_visualizer.py

@@ -267,6 +267,10 @@ def _get_agent_model(self) -> str | None:
 
     def on_event(self, event: Event) -> None:
         """Main event handler that creates widgets for events."""
+        # Dismiss any pending critic feedback widgets when new events arrive,
+        # since the agent has continued working (user didn't interact with them)
+        self._run_on_main_thread(self._dismiss_pending_feedback_widgets)
+
         # Check for TaskTrackerObservation to update/open the plan panel
         if isinstance(event, ObservationEvent) and isinstance(
             event.observation, TaskTrackerObservation

tests/snapshots/test_critic_feedback_snapshots.py

@@ -13,7 +13,7 @@
 from unittest.mock import MagicMock
 
 from textual.app import App, ComposeResult
-from textual.containers import Horizontal
+from textual.containers import Horizontal, VerticalScroll
 from textual.widgets import Button, Footer, Static
 
 from openhands_cli.theme import OPENHANDS_THEME
@@ -124,3 +124,48 @@ def compose(self) -> ComposeResult:
             CriticFeedbackTestApp(),
             terminal_size=(100, 20),
         )
+
+    def test_critic_feedback_widget_inside_vertical_scroll(self, snap_compare):
+        """Snapshot test: feedback widget inside VerticalScroll (real app context).
+
+        In the real app, CriticFeedbackWidget is mounted inside a VerticalScroll
+        container. This test reproduces the layout context to verify all 5 buttons
+        are visible.
+
+        Relates to: https://github.com/OpenHands/OpenHands-CLI/issues/641
+        """
+
+        class CriticFeedbackInScrollApp(App):
+            CSS = """
+            Screen {
+                background: $background;
+            }
+            #scroll_view {
+                width: 100%;
+                height: 1fr;
+            }
+            #content {
+                width: 100%;
+                height: auto;
+                padding: 1;
+            }
+            """
+
+            def __init__(self, **kwargs):
+                super().__init__(**kwargs)
+                self.register_theme(OPENHANDS_THEME)
+                self.theme = OPENHANDS_THEME.name
+
+            def compose(self) -> ComposeResult:
+                with VerticalScroll(id="scroll_view"):
+                    yield Static(
+                        "Sample conversation content above the widget",
+                        id="content",
+                    )
+                    yield MockCriticFeedbackWidget()
+                yield Footer()
+
+        assert snap_compare(
+            CriticFeedbackInScrollApp(),
+            terminal_size=(100, 20),
+        )

tests/tui/modals/test_exit_modal.py

@@ -1,12 +1,54 @@
 """Tests for exit confirmation modal functionality."""
 
+import re
+from pathlib import Path
 from unittest import mock
 
 from textual.widgets import Button
 
 from openhands_cli.tui.modals.exit_modal import ExitConfirmationModal
 
 
+# Path to exit modal TCSS relative to the modal module
+EXIT_MODAL_TCSS_PATH = (
+    Path(__file__).resolve().parents[3]
+    / "openhands_cli"
+    / "tui"
+    / "modals"
+    / "exit_modal.tcss"
+)
+
+
+class TestExitModalCssScoping:
+    """Tests that exit modal CSS doesn't leak global styles.
+
+    Regression test for GitHub issue #641: an unscoped `Button { width: 100%; }`
+    rule in exit_modal.tcss was overriding CriticFeedbackWidget button styles,
+    causing only the first button to be visible.
+    """
+
+    def test_button_rule_is_scoped_to_dialog(self):
+        """Button CSS rules must be scoped (e.g., #dialog Button), not global.
+
+        An unscoped `Button { ... }` rule would override button styles
+        in every other widget (e.g., CriticFeedbackWidget).
+        """
+        tcss_content = EXIT_MODAL_TCSS_PATH.read_text()
+
+        # Find all Button selector lines (ignoring comments)
+        # Match lines like "Button {" but not "#dialog Button {" or ".foo Button {"
+        unscoped_button_rules = re.findall(
+            r"^\s*Button\s*\{", tcss_content, re.MULTILINE
+        )
+
+        assert not unscoped_button_rules, (
+            "Found unscoped global 'Button' rule(s) in exit_modal.tcss. "
+            "Button rules must be scoped to a parent (e.g., '#dialog Button') "
+            "to avoid overriding button styles in other widgets. "
+            "See: https://github.com/OpenHands/OpenHands-CLI/issues/641"
+        )
+
+
 class TestExitConfirmationModal:
     """Tests for the ExitConfirmationModal component."""