Skip to content

tests: prevent browser opening in device flow test#664

Open
llamantino wants to merge 1 commit intoOpenHands:mainfrom
llamantino:fix-device-flow-browser-opening
Open

tests: prevent browser opening in device flow test#664
llamantino wants to merge 1 commit intoOpenHands:mainfrom
llamantino:fix-device-flow-browser-opening

Conversation

@llamantino
Copy link
Copy Markdown
Contributor

  • A human has tested these changes.

Why

Running this test can open a browser as a side effect. This is unnecessary for a test run.

Summary

  • mock browser opening in the device flow poll error test to avoid external side effects during test runs

Issue Number

How to Test

Run uv run pytest -v tests/auth/test_device_flow.py::TestDeviceFlowClient::test_authenticate_poll_error and verify the test passes without opening a browser.

Video/Screenshots

Type

  • Bug fix
  • Feature
  • Refactor
  • Breaking change
  • Docs / chore

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant