refactor(charts): embed service charts as openhands subcharts#695
Draft
jlav wants to merge 1 commit into
Draft
Conversation
Move runtime-api, automation, plugin-directory, and integrations-hub from charts/<name>/ into charts/openhands/charts/ as embedded subcharts. They no longer version or publish independently; changes ship via an openhands chart version bump. crd-check stays published (charts/infra depends on it by OCI ref). Follow-up to #665.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #665, which made the openhands chart the single source of truth for vetted dependency combinations by adding
enabledflags everywhere.This repo still vendored runtime-api, automation, plugin-directory, and integrations-hub as top-level charts, each versioned and published to GHCR on its own. But nothing consumes them standalone - they only ever ship as part of openhands. Keeping them independently versioned meant a change to any one of them needed its own version bump, its own publish, and a matching dependency-version bump in the umbrella, plus a pile of CI choreography to rewrite OCI refs to alpha previews on PRs.
This folds those four into
charts/openhands/charts/as standard embedded subcharts. Their versions are now frozen and changes ride along with an openhands version bump. That collapses the release path to match the model #665 set up.crd-check stays published independently, since
charts/infradepends on it by OCI reference.Helm Chart Checklist
versionfield inChart.yamlfor each modified chartAdditional Notes
The subchart dependency entries in the umbrella
Chart.yamlare now repository-less withversion: "*", kept only for theirconditionflags. Theenabledgating from #665 carries over unchanged.A couple of things worth flagging for review:
helm dependency updateon each embedded subchart before packaging the umbrella..gitignorechanged fromcharts/**/chartstocharts/**/charts/*.tgzso the embedded sources stay tracked while vendored archives stay ignored.I verified
helm templateof the new layout renders byte-identical to the current OCI-based umbrella,make lintpasses end-to-end (it previously couldn't even package the umbrella locally because of the unpublished automation OCI pin), and the update-script test suite is green. I haven't tested a live upgrade install from a previously published version, though.