fix(chess): strip nested PGN variations on import - #1177
Merged
chinweobtagaz merged 1 commit intoSep 2, 2026
Merged
Conversation
chinweobtagaz
merged commit Sep 2, 2026
3ac840f
into
OpenKnight-Foundation:main
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_movesstripped variations with a single\([^()]*\)regex pass, which only matches the innermost parentheses. On nested variations like(1. d4 (2. c4) Nf6)it removed the inner(2. c4)and left the outer parens and their moves behind, so those tokens reached SAN validation and failed the import with a 422.This walks the movetext tracking parenthesis depth instead, so every nesting level is removed in one pass, and it tolerates unbalanced parens without panicking.
Added a parse test with a nested variation (which errored before) plus a unit test for the helper.
Closes #1176.