fix: unbreak Backend CI (validation + archiving compile errors) - #1181
Merged
chinweobtagaz merged 1 commit intoSep 2, 2026
Merged
Conversation
Contributor
Author
|
On the red CI here: this clears the validation and archiving compile errors, but main also has the I left metrics out because the fix is a labeled-metrics design choice ( |
chinweobtagaz
merged commit Sep 2, 2026
cdeafc6
into
OpenKnight-Foundation:main
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend CI is red on main:
cargo test --workspacedoesn't compile, so no tests run and every open backend PR inherits the red. A few crates were merged non-compiling. This fixes two of them; the rest is tracked in #1180.validation:
get/incr/expire/set_ex) need theAsyncCommandstrait in scope. It wasn't imported.Arcis used byValidationWebSocketHandlerbutstd::sync::Arcwasn't imported.position_cacheis mutated through&self(the validator is shared viaArc), so a plainHashMapfield can't work. Wrapped it in aMutexwith short locked sections that don't span awaits, and fixed a borrow-of-moved inparse_uci_move(computeis_castlingbefore movingfrom_square/to_squareinto the struct).archiving:
reqwestneeds itsmultipartfeature for the Arweave upload.cost_usdisOption<f64>but was assigned an unwrappedf64in two branches.metadata.tagsis aVec, not anOption.form_datamixes literal and formatted keys, so it needsStringkeys.Verified locally: both crates compile and
cargo test -p validation/-p chesspass. This doesn't fully green CI on its own (themetricscrate, see #1180, still needs fixing), but it clears two of the blockers.